Fix/vault withdraw event shape#310
Merged
greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom Apr 24, 2026
Merged
Conversation
Standardize withdraw/withdraw_to events using a documented WithdrawEventData struct. Clean up duplicate code in lib.rs and improve fuzz test reliability by handling pause state correctly.
Author
|
Hello @maintainer This issue has been merged and closed but i'm yet to get a point |
Author
|
Hello Maintainer I'm yet to receive my point for the issue fixed |
1 similar comment
Author
|
Hello Maintainer I'm yet to receive my point for the issue fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246
i128::MAX / 2) were allowed, causing the underlying USDC token balance to overflowi128::MAX. Atoken_simtracker was added to prevent the test sequence from attempting deposits that breach the token standard's absolute limits.set_allowed_depositor) where rawAddresses were passed instead ofOption<Address>.contracts/settlement/src/test.rs, ensuring the entire workspace compiles seamlessly without any Clippy warnings.🛡️ Security / Context
WithdrawEventDatahas no impact on existing storage or balance invariant checks, but provides critical context for indexing infrastructure.batch_deductnow formally requires an unpaused state, hardening the vault's emergency circuit breaker against batch deductions during an incident.Closes(#246)